PING^1: [PATCH 2/2] Mark internal unistd functions hidden in ld.so

H.J. Lu hjl.tools@gmail.com
Wed Jan 6 20:56:00 GMT 2016


On Wed, Jan 6, 2016 at 11:44 AM, Adhemerval Zanella
<adhemerval.zanella@linaro.org> wrote:
> LGTM, only one comment below regarding some comments inclusion.
>
> The only nit about the patchset is the creation of another header with
> platform specific header.  I think we can move both dl-mman.h and
> dl-unistd.h to common header (maybe dl-sysdep.h), but we can push it
> a future cleanup.

Sure.

> I think you should also add a comment, as you did for dl-mman.h, explaining
> why we can't hide __close, __getcwd, __getpid, _libc_read and __libc_write
> on Hurd.
>

This is what I checked in.

Thanks.

-- 
H.J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Mark-internal-unistd-functions-hidden-in-ld.so.patch
Type: text/x-patch
Size: 5414 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20160106/f2aaae62/attachment.bin>


More information about the Libc-alpha mailing list