If this fixes bug 17950, you need to include [BZ #17950] in your ChangeLog entry, mention the bug number in your commit message and close that bug as fixed with the milestone set appropriately once the fix is in. (This is not a review or approval of the patch.) -- Joseph S. Myers joseph@codesourcery.com