[PATCH] argp: Use fwrite_unlocked instead of __fxprintf when !_LIBC

Florian Weimer fweimer@redhat.com
Mon Jan 4 19:38:00 GMT 2016


On 01/04/2016 04:36 PM, Joseph Myers wrote:
> On Mon, 4 Jan 2016, Florian Weimer wrote:
> 
>> On 01/01/2016 09:20 PM, Khem Raj wrote:
>>
>>> +#ifdef _LIBC
>>>        __fxprintf (fs->stream, "%.*s", (int) (fs->p - fs->buf), fs->buf);
>>> +#else
>>> +      fwrite_unlocked (fs->buf, 1, fs->p - fs->buf, fs->stream);
>>> +#endif
>>
>> Why not use fwrite_unlocked unconditionally?
> 
> Does fwrite_unlocked work on wide-oriented streams in glibc (the point of 
> __fxprintf as I understand it being to work whatever the orientation of 
> the stream)?

Oh, I didn't know this was the point of fxprintf.  No, in this case,
using fwrite_unlocked would not work (in fact, it would be undefined).

Florian



More information about the Libc-alpha mailing list