[PATCH] argp: Use fwrite_unlocked instead of __fxprintf when !_LIBC

Mike Frysinger vapier@gentoo.org
Mon Jan 4 19:31:00 GMT 2016


On 04 Jan 2016 11:08, Khem Raj wrote:
> On Fri, Jan 1, 2016 at 7:21 PM, Mike Frysinger wrote:
> > On 01 Jan 2016 20:20, Khem Raj wrote:
> >> __fxprintf is not available when argp is built outside libc
> >>
> >> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> >> ---
> >>  ChangeLog             | 5 +++++
> >>  argp/argp-fmtstream.c | 4 ++++
> >
> > i forget where we document these things, but usually modules that utilize
> > _LIBC are kept in sync with other projects, and we often like to see such
> > changes sent/merged simultaneously with them.  this one looks like gnulib.
> 
> gnulib already have a check for it introduced via this commit
> 
> http://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=c72047a1ed44c8c9509f1593d726ccd63ceb965c

that's stronger justification imo for merging

> it checks for USE_IN_LIBIO

it would be nice if we could fully sync these two files so they're
in agreement again, but i won't force that on you :).
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20160104/ef102543/attachment.sig>


More information about the Libc-alpha mailing list