[PATCH] Eliminate redundant sign extensions in pow()

Tulio Magno Quites Machado Filho tuliom@linux.vnet.ibm.com
Mon Jan 4 16:58:00 GMT 2016


Anton Blanchard <anton@samba.org> writes:

>> OK with a ChangeLog entry if you've done the usual testing with the 
>> testsuite without any new ulps for pow appearing (you didn't say).
>
> Thanks Joseph.
>
> --
>
> When looking at the code generated for pow() on ppc64 I noticed quite
> a few sign extensions. Making the array indices unsigned reduces the
> number of sign extensions from 24 to 7.
>
> Tested for powerpc64le and x86_64.
>
> 2015-11-20  Anton Blanchard <anton@samba.org>
>
> 	* sysdeps/ieee754/dbl-64/e_pow.c (log1): Use unsigned int
> 	for array indices.
> 	* sysdeps/ieee754/dbl-64/e_pow.c (my_log2): Likewise.

LGTM too.

I just pushed it as 0a1f1e78.

Thanks!

-- 
Tulio Magno



More information about the Libc-alpha mailing list