[PATCH 2/3] posix: execvpe cleanup

Paul Eggert eggert@cs.ucla.edu
Mon Feb 29 19:34:00 GMT 2016


On 02/29/2016 10:33 AM, Adhemerval Zanella wrote:
> +      if ((argc+1) == INT_MAX)

This is clearer as:

    if (argc == INT_MAX - 1)

Spaces around binary "+" and/or "-", please, and avoid redundant parens.

To some extent I've reviewed the code so often that I'm burned out as a 
reviewer, but it looks OK to me other than these minor glitches.



More information about the Libc-alpha mailing list