[PATCH 3/5] Consolidate off_t/off64_t syscall argument passing

Mike Frysinger vapier@gentoo.org
Wed Feb 24 21:41:00 GMT 2016


On 24 Feb 2016 17:48, Adhemerval Zanella wrote:
> +#define SYSCALL_LL(__val)   \
> +  __LONG_LONG_PAIR (__val >> 31, __val)
> +#define SYSCALL_LL64(__val) \
> +  __LONG_LONG_PAIR ((long) (__val >> 32), (long) (__val & 0xffffffff))

shouldn't __val be parenthesized ?

#define SYSCALL_LL(__val) __LONG_LONG_PAIR ((__val) >> 31, (__val))

also, does this really need to be __val ?  it's a macro so it's not
like someone using a var or define named __val would affect this.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20160224/6853edae/attachment.sig>


More information about the Libc-alpha mailing list