[PATCH 4/4] Consolidate pwrite/pwrite64 implementations

[Mike Frysinger]

On 23 Feb 2016 12:17, Adhemerval Zanella wrote:
> 	* sysdeps/unix/sysv/linux/arm/pwrite.c: Remove file.
> 	* sysdeps/unix/sysv/linux/arm/pwrite64.c: Likewise.
> 	* sysdeps/unix/sysv/linux/generic/wordsize-32/pwrite.c: Likewise.
> 	* sysdeps/unix/sysv/linux/generic/wordsize-32/pwrite64.c: Likewise.
> 	* sysdeps/unix/sysv/linux/mips/pwrite.c: Likewise.
> 	* sysdeps/unix/sysv/linux/mips/pwrite64.c: Likewise.
> 	* sysdeps/unix/sysv/linux/powerpc/powerpc32/pwrite.c: Likewise.
> 	* sysdeps/unix/sysv/linux/powerpc/powerpc32/pwrite64.c: Likewise.
> 	* sysdeps/unix/sysv/linux/sh/pwrite.c: Likewise.
> 	* sysdeps/unix/sysv/linux/sh/pwrite64.c: Likewise.

you aren't removing the mips/sh implementations anymore

> --- a/sysdeps/unix/sysv/linux/mips/pwrite.c
> +++ b/sysdeps/unix/sysv/linux/mips/pwrite.c
>
> +/* The n32 have sizeof(off_t) != sizeof(off64_t) so we can't strong/weak
> +   alias the pwrite to pwrite64.  We undefine the __ASSUME_WORDSIZE64_ILP32
> +   so two implementation are built.  */
> +#if _MIPS_SIM == _ABIN32
> +# undef __ASSUME_WORDSIZE64_ILP32
>  #endif
>
> +#include <sysdeps/unix/sysv/linux/pwrite.c>

this style seems fragile to me.  would it not be better to add a
specific knob for files to set ?
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20160223/4aa7929e/attachment.sig>