[PATCH] BZ #19590: Fixed build of shared objects that use libmvec.so functions

[Andrew Senkevich]

2016-02-17 23:06 GMT+03:00 H.J. Lu <hjl.tools@gmail.com>:
> On Wed, Feb 17, 2016 at 11:30 AM, Andrew Senkevich
> <andrew.n.senkevich@gmail.com> wrote:
>> 2016-02-17 21:44 GMT+03:00 Joseph Myers <joseph@codesourcery.com>:
>>> On Wed, 17 Feb 2016, Andrew Senkevich wrote:
>>>
>>>> Is attached version finally Ok for trunk?
>>>
>>> Please resubmit, with the coding style issues fixed and tests moved to
>>> test-skeleton.c unless there's a reason they can't use it, after the
>>> freeze is over.  This is much too risky to consider during the freeze, and
>>> would need to wait a while on master before any backports could be
>>> considered (e.g. the new tests could break the testsuite build in some
>>> configurations for unforeseen reasons).
>>
>> May be separate fix and tests to commit fix earlier?
>>
>
> This is a good idea.  Please submit a fix-only patch.

2016-02-18  Andrew Senkevich  <andrew.senkevich@intel.com>
                    H.J. Lu  <hongjiu.lu@intel.com>

        [BZ #19590]
        * sysdeps/x86_64/fpu/svml_finite_alias.S (ALIAS_IMPL): Use PIC
        relocation.

diff --git a/sysdeps/x86_64/fpu/svml_finite_alias.S
b/sysdeps/x86_64/fpu/svml_finite_alias.S
index 0062fe4..2dcfc37 100644
--- a/sysdeps/x86_64/fpu/svml_finite_alias.S
+++ b/sysdeps/x86_64/fpu/svml_finite_alias.S
@@ -23,8 +23,7 @@

 #define ALIAS_IMPL(alias, target) \
 ENTRY (alias); \
- call target; \
- ret; \
+ jmp *target@GOTPCREL(%rip); \
 END (alias)

  .text


Ok to commit?


--
WBR,
Andrew