[PATCH] nptl: Avoid expected SIGALRM in most tests [BZ #20432]

Andreas Schwab schwab@suse.de
Thu Dec 15 15:56:00 GMT 2016


On Aug 17 2016, fweimer@redhat.com (Florian Weimer) wrote:

> diff --git a/nptl/tst-stdio1.c b/nptl/tst-stdio1.c
> index 2d44c16..4250e53 100644
> --- a/nptl/tst-stdio1.c
> +++ b/nptl/tst-stdio1.c
> @@ -21,6 +21,10 @@
>  #include <stdio.h>
>  #include <unistd.h>
>  
> +static int do_test (void);
> +
> +#define TEST_FUNCTION do_test ()
> +#include "../test-skeleton.c"
>  
>  static void *tf (void *a)
>  {
> @@ -43,14 +47,10 @@ do_test (void)
>        _exit (1);
>      }
>  
> -  pthread_join (th, NULL);
> +  delayed_exit (1);
> +  xpthread_join (th);
>  
>    puts ("join returned");
>  
> -  return 0;
> +  return 1;
>  }
> -
> -
> -#define EXPECTED_SIGNAL SIGALRM
> -#define TEST_FUNCTION do_test ()
> -#include "../test-skeleton.c"

That doesn't work, the test now always times out because exit blocks on
flockfile.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."



More information about the Libc-alpha mailing list