[GLIBC][PATCH] Remove strdup inlines

Zack Weinberg zackw@panix.com
Mon Dec 12 12:26:00 GMT 2016


On Mon, Dec 12, 2016 at 7:00 AM, Wilco Dijkstra <Wilco.Dijkstra@arm.com> wrote:
> Remove the str(n)dup inlines from string/bits/string2.h.  Although inlining
> calls with constant strings shows a small (~10%) performance gain, strdup is
> typically used in error reporting code, so not performance critical.

Looks good to me.

This is the sole user of __need_malloc_and_calloc, so please also remove the
logic implementing that from {include,stdlib}/stdlib.h.

zw



More information about the Libc-alpha mailing list