[RFC PATCH] Deprecate _REENTRANT and _THREAD_SAFE.

Zack Weinberg zackw@panix.com
Tue Dec 6 16:43:00 GMT 2016


On 12/06/2016 10:36 AM, Florian Weimer wrote:
> On 12/06/2016 04:22 PM, Zack Weinberg wrote:
>> For many years, the only effect of these macros has been to make
>> unistd.h declare getlogin_r.  _POSIX_C_SOURCE >= 199506L also causes
>> this function to be declared.  However, people who don't carefully
>> read all the headers might be confused into thinking they need to
>> define _REENTRANT for any threaded code (as was indeed the case a long
>> time ago).
> 
> You should get rid of the internal #define and #undef of _REENTRANT, too.

Do you mean the ones in libc-symbols.h and check-installed-headers.sh?
Those are the only ones I see grepping.

This updated patch takes care of that and also the discussion in
creature.texi.  (creature.texi needs a thorough overhaul, but let's not
worry about that now.)  Also, it's been tested on x86-64-linux.

zw

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Deprecate-_REENTRANT-and-_THREAD_SAFE.patch
Type: text/x-patch
Size: 9544 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20161206/c5cedfe3/attachment.bin>


More information about the Libc-alpha mailing list