[PATCHv4 8/8] Convert remaining complex function to generated files

Joseph Myers joseph@codesourcery.com
Fri Aug 19 20:46:00 GMT 2016


On Thu, 18 Aug 2016, Paul E. Murphy wrote:

> +#if M_LIBM_NEED_COMPAT (clog10)
> +  /* __clog10 was accidentally exported in past versions.  */

I'm not sure that comment is accurate.  __clog10 is used in tgmath.h to 
provide support for type-generic log10 for complex arguments.  That looks 
fairly deliberate to me as a public ABI.  One could argue that tgmath.h 
should actually use clog10 not __clog10 there, since it's inside a 
conditional on __USE_GNU, but one could also argue that __clog10 should be 
exported for use by the C++ standard library which has to provide log10 
for complex numbers (libstdc++ doesn't currently use clog10 or __clog10 
for this, but could, and logically it should be __clog10 for namespace 
reasons; cf past discussions about providing more __* exports to eliminate 
the need for g++ to define _GNU_SOURCE by default).

-- 
Joseph S. Myers
joseph@codesourcery.com



More information about the Libc-alpha mailing list