[glibc PATCH] fcntl: put F_OFD_* constants under #ifdef __USE_FILE_OFFSET64

Florian Weimer fweimer@redhat.com
Thu Aug 18 09:00:00 GMT 2016


On 08/17/2016 11:48 PM, Jeff Layton wrote:
> So yeah, I think what I proposed before would probably be fine. But now
> that Michael pushed the issue, it's dawned on me that we may be able to
> get away with supporting it better if we turn the compatability
> mechanism on its head and use F_OFD_*32 constants in the non-LFS case.

That's rather confusing to programmers, though.

We then have:

F_OFD_SETLK     always 64-bit
F_SETLK         32-bit or 64-bit
F_SETLK64       always 64-bit (not recommended)
F_OFD_SETLK32   always 32-bit

Until we make fcntl type-safe, this doesn't really fly, I'm afraid.

Florian



More information about the Libc-alpha mailing list