[PATCH 5/6] ldbl-128: Use L(x) macro for long double constants

Paul E. Murphy murphyp@linux.vnet.ibm.com
Tue Aug 16 19:19:00 GMT 2016



On 08/16/2016 01:12 PM, Joseph Myers wrote:
> This is a case where the script that generated the patch is as important 
> for review as the patch itself.  If there are some automated and some 
> manual changes, they need separating, e.g. a patch for using integer 
> constants separate from a patch converting remaining *L constants to use 
> the macro.
>

Do the means to arrive at the patch really matter?  I honestly didn't keep
track of them since most were ad-hoc regex replacements.  I walked through
each file and applied, and fixed as necessary.  These files did not lend
themselves well to simple regex replacement.  I walked through these changes
in a graphical difftool (meld) as looking at a unified diff is both
tedious and error prone.

Moreso, is the generic naming and usage of the L(x) macro acceptable?  If
so, I can rework into smaller changes once we find general consensus on
how to share these files with float128.



More information about the Libc-alpha mailing list