[PATCHv2 03/11] Support for type-generic libm function implementations libm

Paul E. Murphy murphyp@linux.vnet.ibm.com
Thu Aug 11 14:43:00 GMT 2016



On 08/10/2016 08:22 PM, Joseph Myers wrote:
> On Wed, 10 Aug 2016, Paul E. Murphy wrote:
> 
>> diff --git a/math/Makefile b/math/Makefile
>> index 567b7ed..7451e4e 100644
>> --- a/math/Makefile
>> +++ b/math/Makefile
>> @@ -274,7 +274,7 @@ generated += $(addsuffix .c,$(call type-foreach,$(gen-libm-calls:%=%$(s)))) \
>>  # Create wrappers in the math build directory.
>>  $(objpfx)gen-libm-templates.stmp:
>>         for gfunc in $(gen-libm-calls); do                                \
>> -         gfunc_basefile=$${gfunc/F/}_template.c;                         \
>> +         gfunc_basefile=$${gfunc%F*}$${gfunc#*F}_template.c;             \
>>           for type in $(foreach t,$(types),$(t)__$(type-$(t)-suffix)); do \
>>             func=$(objpfx)$${gfunc/F/$${type#*__}};                       \
> 
> There's a further unfixed instance of this non-POSIX shell usage.
> 
> Please send a complete fixed patch.
> 

That seems to be the last bash-ism.  I've also applied some other
cleanups intended to improve readability.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Support-for-type-generic-libm-function-implementatio.patch
Type: text/x-patch
Size: 42437 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20160811/975d7f52/attachment.bin>


More information about the Libc-alpha mailing list