[PATCH] Get rid of array-bounds warning in __kernel_rem_pio2[f] with gcc 6.1 -O3.
Joseph Myers
joseph@codesourcery.com
Wed Aug 10 11:38:00 GMT 2016
On Tue, 2 Aug 2016, Stefan Liebler wrote:
> diff --git a/sysdeps/ieee754/dbl-64/k_rem_pio2.c b/sysdeps/ieee754/dbl-64/k_rem_pio2.c
> + /* On s390x gcc 6.1 -O3 produces the warning "array subscript is below
> + array bounds [-Werror=array-bounds]". Only __ieee754_rem_pio2l()
> + calls __kernel_rem_pio2f() for normal numbers and |x| > 3pi/4.
__kernel_rem_pio2f seems like the wrong function to reference in a comment
in this file. Please review the actual call sequences in each case to
make sure the right functions are referenced. Also, the GNU Coding
Standards say not to use () after a function name when referencing the
function:
Please do not write @samp{()} after a function name just to indicate
it is a function. @code{foo ()} is not a function, it is a function
call with no arguments.
> + /* On s390x gcc 6.1 -O3 produces the warning "array subscript is
> + below array bounds [-Werror=array-bounds]". Only
> + __ieee754_rem_pio2f() calls __kernel_rem_pio2f() for normal
Likewise, don't use () after the function name.
--
Joseph S. Myers
joseph@codesourcery.com
More information about the Libc-alpha
mailing list