[PATCH] Avoid attempt for runtime checks if all environments are defined

Maciej W. Rozycki macro@imgtec.com
Fri Aug 5 15:09:00 GMT 2016


On Thu, 23 Jun 2016, Siddhesh Poyarekar wrote:

> > > macros undefined, which means that no such additiona execve is needed
> > 
> > "additional"
> > 
> > > +  #define ALL_ENVIRONMENTS_DEFINED 1
> > 
> > don't indent the #
> 
> Thanks, pushed with those changes.

 This broke `mips-linux-gnu' compilation with GCC 6:

In file included from ./posix-conf-vars.h:30:0,
                 from getconf.c:30:
.../posix/posix-conf-vars-def.h:999:21: error: 'nspecs' defined but not used [-Werror=unused-const-variable]
 static const size_t nspecs = sizeof (specs) / sizeof (specs[0]);
                     ^~~~~~

cc1: all warnings being treated as errors
make[2]: *** [.../posix/getconf.o] Error 1

-- it looks to me like you'd need to define NEED_SPEC_ARRAY to 0 if 
setting ALL_ENVIRONMENTS_DEFINED (but then it looks like a chicken-and-egg 
problem to me requiring a solution more complex than just fiddling with 
NEED_SPEC_ARRAY, so I'm leaving it up to you to sort out).

  Maciej



More information about the Libc-alpha mailing list