[PATCHv2 01/11] Refactor part of math Makefile

Paul E. Murphy murphyp@linux.vnet.ibm.com
Wed Aug 3 17:13:00 GMT 2016



On 08/02/2016 04:33 PM, Joseph Myers wrote:
> On Fri, 1 Jul 2016, Paul E. Murphy wrote:
> 
>> +libm-compat-calls = w_lgamma_compatf w_lgamma_compat k_standard k_standardf \
>> +	$(libm-compat-calls-ldouble-$(long-double-fcts))
> 
> The indentation on the second line here is wrong (should line up with the 
> first non-whitespace character after the '=' on the line above, i.e. 
> indent with two tabs and four spaces instead of just one tab).

Fixed.

> This patch is OK with that fixed, provided you've verified that the sets 
> of files built and tests run are the same before and after the patch, on 
> platforms with and without long double having a distinct ABI from double.
> 

I gave this whirl on the more complete linaro cross-toolchain for arm.  The
same set of test files are generated before and after this patch.

Committed as b9e05ed.



More information about the Libc-alpha mailing list