[PATCH] hesiod_end: Do not call res_nclose(&_res) [BZ #19573]
Anders Kaseorg
andersk@mit.edu
Wed Apr 27 15:36:00 GMT 2016
On Sat, 23 Apr 2016, Anders Kaseorg wrote:
> Thanks for the review!
>
> > […]
>
> hesiod/hesiod.c is not in GNU style; I preserved its existing style as per
> https://sourceware.org/glibc/wiki/Style_and_Conventions#Files_not_formatted_according_to_the_GNU_standard.
>
> > […]
>
> I agree: this file is only used in nss_hesiod, whose only exported symbols
> are the NSS interface.
>
> Also, the test I used is the same as what __hesiod_res_set already uses
> before calling res_nclose. This may not be strong evidence by itself,
> because it happens that __hesiod_res_set is never called in a way that
> satisfies this test, but at least it’s consistent.
Is this ready to be committed, or do you still have concerns?
Anders
More information about the Libc-alpha
mailing list