[PATCH 16/17 v5] x86, pthread_cond_*wait: Do not depend on %eax not being clobbered

Nix nix@esperi.org.uk
Mon Apr 4 22:09:00 GMT 2016


On 23 Mar 2016, Florian Weimer told this:

> On 03/15/2016 12:36 AM, Nix wrote:
>> On 14 Mar 2016, Florian Weimer said:
>> 
>>> On 03/13/2016 04:17 PM, Nix wrote:
>>>> From: Nick Alcock <nick.alcock@oracle.com>
>>>
>>>> 	* sysdeps/unix/sysv/linux/i386/pthread_cond_timedwait.S: Reload
>>>> 	call-clobbered %eax on retry path.
>>>> 	* sysdeps/unix/sysv/linux/i386/pthread_cond_wait.S: Likewise.
>>>
>>> Looks good.  Can you commit this yourself, or do you need someone to
>>> commit it for you?
>> 
>> I don't have commit rights, so if you or someone else wants to commit
>> it, commit away!
>
> I have pushed this.

Thank you!

... now, is there anything I can do to the rest to make people happier?
I think I've addressed all the review comments...

-- 
NULL && (void)



More information about the Libc-alpha mailing list