[PATCHv2] powerpc: Add optimized P8 strspn

Segher Boessenkool segher@kernel.crashing.org
Sat Apr 2 23:40:00 GMT 2016


Hi Paul,

Sorry for not reviewing this earlier.  Some minor things; this is
not a full review.

> +++ b/sysdeps/powerpc/powerpc64/multiarch/strspn.c
> @@ -0,0 +1,35 @@
> +/* Multiple versions of strspn. PowerPC64 version.

Two spaces after full stop.

> +++ b/sysdeps/powerpc/powerpc64/power8/strspn.S

> +/* size_t [r3] strspn (const char *string [r3],
> +                       const char *needleAccept [r4]  */

Missing ")".

> +	lvsr	v11, r0, r3

That is 0, not r0.

> +	lvx	v0, r0, r3	/* Note, unaligned load ignores lower bits.  */

Same for lvx.

Interesting algo :-)


Segher



More information about the Libc-alpha mailing list