[PATCH] [BZ #18970]: Reference of pthread_setcancelstate in libc.a

[H.J. Lu]

On Thu, Sep 17, 2015 at 3:51 PM, Joseph Myers <joseph@codesourcery.com> wrote:
> On Thu, 17 Sep 2015, Roland McGrath wrote:
>
>> > I don't know what combination of false positives and real problems you'd
>> > find if linknamespace.pl stopped special-casing weak symbols.
>>
>> I think we should look into that.  The name space issues are orthogoal to
>> weakness in all scenarios I can think of.  If code reached by function foo
>> is affected at all by a symbol bar and bar is in the application name space
>> for some application that can use foo, then there is a problem.
>
> This patch effects such a change (weak undefined symbols are required to
> be in the standard namespace - but it's still the case that such symbols
> are not followed recursively to find other symbols to check the namespace
> of, because the linker wouldn't bring in a definition of a function
> referenced only weakly).  It turns out that pthread_setcancelstate is the
> only such function showing up in linknamespace failures with this patch in
> testing on x86_64 and x86 (so once HJ's fix, minus testcase, is in, I can
> commit this patch).
>
> 2015-09-17  Joseph Myers  <joseph@codesourcery.com>
>
>         * conform/linknamespace.pl: Require weak undefined symbols to be
>         in the standard namespace.
>         (%strong_syms): Rename to %seen_syms.
>         (%strong_seen): Rename to %seen_where.
>
>

Here is my patch again.  OK for master?

-- 
H.J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Use-__pthread_setcancelstate-in-libc.a.patch
Type: text/x-patch
Size: 9948 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20150917/8b7250b6/attachment.bin>