[PATCH] [BZ #18970]: Reference of pthread_setcancelstate in libc.a
H.J. Lu
hjl.tools@gmail.com
Thu Sep 17 22:32:00 GMT 2015
On Thu, Sep 17, 2015 at 2:57 PM, Joseph Myers <joseph@codesourcery.com> wrote:
> On Thu, 17 Sep 2015, Roland McGrath wrote:
>
>> > Is this a valid test?
>>
>> No. There should be no need for individual tests like that. The
>> linknamespace tests should catch such things if the conform data is correct
>> (and if it's not, the right thing is to fix the conform data).
>
> See one of the caveats listed in linknamespace.pl:
>
> # * Weak undefined symbols are ignored; however, if a code path that
> # references one (even just to check if its address is 0) is executed,
> # that may conflict with a definition of that symbol in the user's
> # program.
>
> I don't know what combination of false positives and real problems you'd
> find if linknamespace.pl stopped special-casing weak symbols.
>
I think it is a mistake to use weak symbols for this purpose.
--
H.J.
More information about the Libc-alpha
mailing list