[PATCH] Fix memory leak in printf_positional
Carlos O'Donell
carlos@redhat.com
Thu Sep 3 12:47:00 GMT 2015
On 09/03/2015 01:48 AM, Paul Pluzhnikov wrote:
> On Wed, Sep 2, 2015 at 10:39 AM, Carlos O'Donell <carlos@redhat.com> wrote:
>
>>>> I think at that point it becomes easier to just use a generator script
>>>> to write the test. Any objection to that?
>>>
>>> I don't object to that given an appropriate comment on why it is being
>>> used.
>>
>> Agreed.
>
> What's the appropriate place to put this comment?
>
> 2015-09-01 Paul Eggert <eggert@cs.ucla.edu>
> Paul Pluzhnikov <ppluzhnikov@google.com>
>
> [BZ #18872]
> * stdio-common/Makefile (tst-printf-bz18872): New test.
> (tst-printf-bz18872-mem.out): Likewise.
> * stdio-common/tst-printf-bz18872.sh: Generate new test.
> * stdio-common/vfprintf.c: Fix memory leaks.
This looks good to me. The comment in tst-printf-bz18872.sh is sufficient for me.
Cheers,
Carlos.
More information about the Libc-alpha
mailing list