[PATCH 01/25] _dl_fini: Rewrite to use VLA instead of extend_alloca

Florian Weimer fweimer@redhat.com
Thu Oct 29 09:04:00 GMT 2015


On 10/28/2015 06:11 AM, Carlos O'Donell wrote:
> On 03/01/2015 08:49 AM, Florian Weimer wrote:
>> In this case, extend_alloca is used to work around the lack of
>> deallocation on scope exit.  A VLA is automatically deallocated in this
>> way, so it is the more fitting approach.
>>
>> To implement this, it is necessary to eliminate the goto.  In addition,
>> this change eliminates the trivially-true assert; the assert is always
>> skipped if nloaded > 0.
> 
> This looks good to me.
> 
> It's a good use of VLA.
> 
> Please check this in.

Thanks, committed

> Make sure you follow GNU Changelog format (you didn't post one for review).

The ChangeLog was posted in 00/25:

  <https://sourceware.org/ml/libc-alpha/2015-03/msg00056.html>

Florian



More information about the Libc-alpha mailing list