[patch] Fix BZ 19165 -- overflow in fread / fwrite

Paul Pluzhnikov ppluzhnikov@google.com
Tue Oct 27 13:59:00 GMT 2015


On Tue, Oct 27, 2015 at 3:51 AM, Joseph Myers <joseph@codesourcery.com> wrote:
> On Mon, 26 Oct 2015, Paul Pluzhnikov wrote:
>
>> static inline bool
>> __attribute__ ((__always_inline))
>> __umull_overflow (size_t a, size_t b)
>
> I don't approve of function naming that quietly embeds the assumption that
> size_t and unsigned long have the same set of values.
>
> If you want a multiplication function for size_t, whether saturating or
> setting an explicit overflow flag, then the name should make clear that
> it's for size_t.

__umul_size_t_overflow ?
__glibc_mul_size_t_overflow ?

Other suggestions?

Thanks.
-- 
Paul Pluzhnikov



More information about the Libc-alpha mailing list