[PATCHv4] powerpc: ABI change - add HWCAP/HWCAP2/platform info to TCB

Paul E. Murphy murphyp@linux.vnet.ibm.com
Fri Oct 23 22:33:00 GMT 2015



On 10/22/2015 08:19 PM, Carlos Eduardo Seo wrote:
> 
> Hi
> 
> After another round of reviews, here is a patch that addresses the problems raised in the last discussion. This should be much simpler than v3. Changes after Joseph's, Roland's and CarlosÂ’ comments:
> 
> * Removed ppc.h API.
> 
> * Cleaned up testcases so that there is no code duplication.
> 
> * Changed PASS/FAIL messages.
> 
> * Changed the initialization function name to be more meaningful and added a comment to Versions explaining why it is there.
> 
> Please note that this patch applies on top of another patch of mine that OÂ’Donell approved today (https://sourceware.org/ml/libc-alpha/2015-10/msg00822.html), but it is not yet committed upstream.
> 
> Thanks,
> 
> 
> 
> 

	* sysdeps/unix/sysv/linux/powerpc/powerpc32/fpu/libc.abilist:
	Included the new __parse_hwcap_and_convert_at_platform symbol in the
	ABI list for GLIBC 2.23.
	* sysdeps/unix/sysv/linux/powerpc/powerpc64/libc-le.abilist:
	Likewise.
	* sysdeps/unix/sysv/linux/powerpc/powerpc64/libc.abilist:
	Likewise.

The changelog still does not match the changed files: s/libc/ld/


+ifeq ($(subdir),nptl)
+sysdep_headers += sys/platform/ppc.h
+tests += test-get_hwcap test-get_hwcap-static
+tests-static += test-get_hwcap-static
+endif

Should "tests += ..." only include the non-static test case?
Am I overlooking something subtle?

BR,
Paul



More information about the Libc-alpha mailing list