[PATCH] getusershell: rewrite from scratch [BZ #18660]

[Mike Frysinger]

On 21 Oct 2015 09:47, Andreas Schwab wrote:
> Mike Frysinger <vapier@gentoo.org> writes:
> > - FreeBSD says "The shells file contains a list of the shells on the
> >   system.  For each shell a single line should be present, consisting of
> >   the shell's path, relative to root.  A hash mark (``#'') indicates the
> >   beginning of a comment; subsequent characters up to the end of the line
> >   are not interpreted by the routines which search the file.  Blank lines
> >   are also ignored."
> 
> This is the ultimate documentation, as the interface was invented by
> BSD.  Why deviate from it?

i disagree.  as i've shown, there is deviation between systems already,
which means admins cannot rely on the behavior being the same everywhere.
hence i turn to the intention of the API and how a reasonable admin would
configure the system, and i think this new version follows that.

note that the API/ABI for tools is unchanged here -- programs all continue
to run and behave the same.  it's changing how the contents of the shells
file is parsed and what entries are returned.
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20151021/35ec7df3/attachment.sig>