[PATCH] 18969 - multiple string test failures due to missing locale dependencies

[Andreas Schwab]

Mike Frysinger <vapier@gentoo.org> writes:

> On 13 Oct 2015 09:14, Andreas Schwab wrote:
>> Mike Frysinger <vapier@gentoo.org> writes:
>> > pretty sure that's not a problem.  $(gen-locales) expands into:
>> > CTYPE_FILES = $(addsuffix /LC_CTYPE,$(LOCALES))
>> > gen-locales := $(addprefix $(common-objpfx)localedata/,$(CTYPE_FILES))
>> >
>> > so it creates one dep per locale.
>> 
>> Each subdir has its independent set of dependencies.
>> 
>> > $(addprefix $(common-objpfx)localedata/,$(CTYPE_FILES)): %: \
>> >   ../localedata/gen-locale.sh \
>> >   $(common-objpfx)locale/localedef \
>> >   ../localedata/Makefile \
>> >   $(addprefix ../localedata/charmaps/,$(CHARMAPS)) \
>> >   $(addprefix ../localedata/locales/,$(LOCALE_SRCS))
>> >     @$(SHELL) ../localedata/gen-locale.sh $(common-objpfx) \
>> >           '$(built-program-cmd-before-env)' '$(run-program-env)' \
>> >           '$(built-program-cmd-after-env)' $@; \
>> >     $(evaluate-test)
>> >
>> > so it generates one locale per invocation.  it looks correct to me.
>> 
>> Different subdirs can build the same locale in parallel.
>
> to be clear, i didn't say otherwise, and i'm aware of this behavior.
> i was pointing out that each subdir builds each required locale in
> parallel and does so with proper targets.

That has no influence on the global behaviour.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."