[PATCH 2/6] Use INLINE_SYSCALL_ERROR_RETURN

[Andreas Schwab]

"H.J. Lu" <hjl.tools@gmail.com> writes:

> On Tue, Oct 13, 2015 at 6:58 AM, Florian Weimer <fweimer@redhat.com> wrote:
>> On 10/13/2015 03:56 PM, H.J. Lu wrote:
>>
>>> It looks (ptrdiff_t) isn't needed.
>>
>> It's not needed on x86_64, but we don't know if there will be
>> architectures which will eventually need it (or already do).  The
>> existing code had -1L, so I assumed it was better to play it safe and
>> mirror that.
>
> Yes, the cast is also needed on x86-64 if __syscall_error is used:
>
> [hjl@gnu-tools-1 tmp]$ cat x.c
> #include <stddef.h>
>
> extern int __syscall_error (void);

__syscall_error returns long on x86_64.

Andreas.

-- 
Andreas Schwab, SUSE Labs, schwab@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."