[COMMITTED] 2.22: Bug 18589: Fix strcoll_l incorrect sorting.

[Florian Weimer]

On 10/12/2015 04:23 AM, Allan McRae wrote:

> Fun story...
> 
> [2015-10-12 09:47] [ALPM] upgraded glibc (2.22-3 -> 2.22-4)
> [2015-10-12 09:47] [ALPM-SCRIPTLET] bash: loadlocale.c:130:
> _nl_intern_locale_data: Assertion `cnt < (sizeof
> (_nl_value_type_LC_COLLATE) / sizeof (_nl_value_type_LC_COLLATE[0]))'
> failed.
> 
> And that was given every time I tried running anything.  It is fun to
> watch your system slowly die while trying to figure a way to remove that
> update from the repos!
> 
> The only changes between our 2.22-3 and 2.22-4 builds were these patches
> you committed.  It seems they introduce incompatibilities to locale
> files generated with builds from earlier in the 2.22 release branch?  I
> was using a relatively benign locale (en_AU.UTF8).

The locale/langinfo.h bits in the reverting commit seem the likely
culprit; that would apply to any locale.  It would have been better to
drop this from the backport.  Unfortunately, it's too late to fix this
now because it would cause similar breakage again for those who suffered
through the previous breakage.

Florian