[PATCH] Harden put*ent functions against data injection [BZ #18724]

[Florian Weimer]

On 10/02/2015 01:15 PM, Joseph Myers wrote:
> i386 build fixed thus.  Committed.
> 
> Fix i386 build after put*ent hardening changes.
> 
> The recent put*ent hardening changes broke the build for i386.  i386
> defines internal_function to __attribute__ ((regparm (3), stdcall)),
> which affects type compatibility, so requiring internal_function to be
> used consistently on declarations and definitions.  This patch adds
> internal_function to the definitions of the new functions using it on
> their declarations.

Ugh, thanks.  I've asked on gcc-help if there is some attribute we can
use to catch this on other architectures as well.

I guess I need to set up things to build everything on i386, too, if GCC
continues to behave this way.

Florian