[PATCH] Implement "make update-all-abi"

[Florian Weimer]

On 11/05/2015 10:39 PM, Roland McGrath wrote:
>> +define update-all-abi
>> +bash $(..)scripts/update-abilist.sh $^ \
> 
> $(BASH)
> 
> But what in this script is actually using a bash extension?  If it doesn't
> take much effort to keep a script POSIX sh-compatible, we should do it.

“set -o pipefail” and the “<( ... )” construct.  I got rid of both.

>> +  $$(find $(..)sysdeps \
>> +    -regextype posix-egrep -regex '.*/$*([^a-z0-9].*)?\.abilist$$' \
>> +    \! -regex '.*/generic/.*')
>> +endef
> 
> Why isn't this find just rolled into the script?

I added a comment explaining its peculiarities.  It is related to
abilist-pattern, so I think its place is in Makerules.

>> +if test $# -lt 3 ; then
> 
> Use [ ... ] rather than test.  No space before a ; like that.

Okay.

>> +    echo "usage: $0 OLD-FILE NEW-FILE FILES-TO-BE-PATCHED..." 1>&2
> 
> Two-space indent.

Okay.

>> +    if ! cmp -s -- "$to_be_patched" "$tmp_patched" ; then
>> +	echo "info: updating $to_be_patched" 1>&2
>> +	cp -- "$tmp_patched" "$to_be_patched"
>> +    fi
> 
> Just call out to move-if-change for this.

No, I have to keep the original file to avoid a /tmp race.  And I think
the additional message has some value.

Florian

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Implement-make-update-all-abi.patch
Type: text/x-patch
Size: 5286 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20151106/d430b0de/attachment.bin>