[COMMITTED PATCH] Split timed-wait functions out of nptl/lowlevellock.c.

Torvald Riegel triegel@redhat.com
Wed May 27 10:21:00 GMT 2015


On Tue, 2015-05-26 at 15:17 -0700, Roland McGrath wrote:
> This lets a configuration replace __lll_timedlock_wait and/or
> __lll_timedwait_tid with different implementations while still
> using the generic code for __lll_lock_wait{,_private}.

It seems you made the split just to support the absolute timeout path
that NaCl futexes provide out of the box.  IMO, this should have been
addressed by fixing the glibc-internal futex API, not by adding a
NaCl-specific variant and lots of new dummy files just to get back to
the common implementation for all other archs.  Didn't we agree to have
as much commonality in our synchronization code as possible?

I'd appreciate if we could have discussion on such patches in the future
before they are committed.  (And I wouldn't mind at all if you'd revert
this patch.)



More information about the Libc-alpha mailing list