Broken MIPS build

Steve Ellcey sellcey@imgtec.com
Thu May 21 20:09:00 GMT 2015


Roland,

This patch:

2015-05-20  Roland McGrath  <roland@hack.frob.com>

	* sysdeps/nacl/pthread-pids.h: New file.
	* sysdeps/nacl/createthread.c: Include <pthread-pids.h>.
	(create_thread): Use __nacl_get_tid to initialize PD->tid.

	* nptl/pthread-pids.h: New file.
	* sysdeps/unix/sysv/linux/pthread-pids.h: New file.
	* nptl/nptl-init.c: Include <pthread-pids.h>.
	(__pthread_initialize_minimal_internal):
	Call __pthread_initialize_pids instead of set_tid_address syscall.

	* sysdeps/unix/sysv/linux/usleep.c: Moved to ...
	* sysdeps/posix/usleep.c: ... here.


Has broken the MIPS glibc build.  The error message is attached below.  I
am guessing I might need to include one (or both) of your new header files
in mips/mips32/sysdep.h to make this build?  Does that sound right to you?


In file included from ../sysdeps/mips/nptl/tls.h:66:0,
                 from ../include/errno.h:27,
                 from nptl-init.c:20:
nptl-init.c: In function '__pthread_initialize_minimal_internal':
nptl-init.c:333:48: error: 'err' undeclared (first use in this function)
   int res = INTERNAL_SYSCALL (set_robust_list, err, 2, &pd->robust_head,
                                                ^
../sysdeps/unix/sysv/linux/mips/mips32/sysdep.h:204:2: note: in definition of macro 'internal_syscall2'
  err = __a3;       \
  ^
nptl-init.c:333:13: note: in expansion of macro 'INTERNAL_SYSCALL'
   int res = INTERNAL_SYSCALL (set_robust_list, err, 2, &pd->robust_head,
             ^
nptl-init.c:333:48: note: each undeclared identifier is reported only once for each function it appears in
   int res = INTERNAL_SYSCALL (set_robust_list, err, 2, &pd->robust_head,
                                                ^
../sysdeps/unix/sysv/linux/mips/mips32/sysdep.h:204:2: note: in definition of macro 'internal_syscall2'
  err = __a3;       \
  ^
nptl-init.c:333:13: note: in expansion of macro 'INTERNAL_SYSCALL'
   int res = INTERNAL_SYSCALL (set_robust_list, err, 2, &pd->robust_head,
             ^
make[2]: *** [/scratch/sellcey/repos/glibc-build2/obj-mips-mti-linux-gnu/glibc/obj_default/nptl/nptl-init.o] Error 1




More information about the Libc-alpha mailing list