[PATCH v3 2/3] Consolidate gettimeofday across aarch64/s390/tile

[Nathan Lynch]

On 05/11/2015 02:11 PM, Adhemerval Zanella wrote:
> This patch removes the architecture specific gettimeofday implementation
> to use the vDSO symbol and consolidate it on a common Linux one.
> Similat to gettime and getres vDSO implementation, each arch that supports
> gettimeofday through vDSO should just implement INLINE_VSYSCALL to access
> the symbol and define HAVE_GETTIMEOFDAY_VSYSCAL as 1.
> 
> Tested on i386, x32, x86_64, ppc64le and aarch64.  Ok to apply?
> 
> Changes from previous version:
> 
> - Fix SYSCALL spelling.
> 
> --
> 
> 	* sysdeps/unix/sysv/linux/aarch64/gettimeofday.c: Remove file.
> 	* sysdeps/unix/sysv/linux/s390/gettimeofday.c: Likewise.
> 	* sysdeps/unix/sysv/linux/tile/gettimeofday.c: Likewise.
> 	* sysdeps/unix/sysv/linux/aarch64/sysdep.h
> 	[HAVE_GETTIMEOFDAY_VSYSCALL]: Define.
> 	* sysdeps/unix/sysv/linux/s390/s390-32/sysdep.h
> 	[HAVE_GETTIMEOFDAY_VSYSCALL]: Likewise.
> 	* sysdeps/unix/sysv/linux/s390/s390-64/sysdep.h
> 	[HAVE_GETTIMEOFDAY_VSYSCALL]: Likewise.
> 	* sysdeps/unix/sysv/linux/tile/sysdep.h
> 	[HAVE_GETTIMEOFDAY_VSYSCALL]: Likewise.
> 	* sysdeps/unix/sysv/linux/gettimeofday.c: New file: gettimeofday
> 	using vDSO syscall macro.
> 

With this change, do the #undefs in init-first.c (seen in aarch64, s390,
powerpc, but not tile or x86) become unnecessary?

# include <dl-vdso.h>
# undef __gettimeofday
# undef __clock_gettime
# undef __clock_getres
# include <libc-vdso.h>


Otherwise looks fine to me.