[PATCH] Improve generic strstr performance.

Ondřej Bílka neleai@seznam.cz
Tue May 12 21:30:00 GMT 2015


On Tue, May 12, 2015 at 02:07:10PM -0700, Roland McGrath wrote:
> > +  if (!needle[1])
> 
> No implicit Boolean coercion:
> 	if (needle[1] == '\0')
> 
> > +          if (needle[2] == '\000')
> 
> Just write '\0' when you are talking about the terminator.  Use '\000' only
> when it's in a context where literal octal values make real sense.
> 
> (I'm not reviewing the substance of your change.)

Ok, will change that before I would commit it.



More information about the Libc-alpha mailing list