[PATCH] powerpc: strstr optimization

Joseph Myers joseph@codesourcery.com
Mon May 11 20:19:00 GMT 2015


On Mon, 11 May 2015, Steven Munroe wrote:

> I think we should move on with (commit) Raji's patch as is. 

Does the patch avoid quadratic worst case?  Quadratic performance in 
strstr is an unambiguous regression, allowing for denial-of-service, that 
should not be introduced on any platform (cf bug 12100).  Indeed, gnulib 
has a configure test for quadratic strstr, so if you introduce quadratic 
worst case then the effect will be that all applications using gnulib 
automatically configure themselves to use gnulib's strstr and not glibc's 
at all.

-- 
Joseph S. Myers
joseph@codesourcery.com



More information about the Libc-alpha mailing list