[COMMITTED PATCH] BZ#18383: Add test case for large alignment in TLS blocks.
H.J. Lu
hjl.tools@gmail.com
Thu May 7 22:30:00 GMT 2015
On Thu, May 7, 2015 at 2:10 PM, Roland McGrath <roland@hack.frob.com> wrote:
> The log entry needs the BZ# marker.
>
> I'm having a hard time finding the calculation in the dynamic-linking case
> that corresponds to this piece of __libc_setup_tls. Since there are two
> places where the logic should match, we really should make it much more
> clear how they relate. If there isn't any obvious refactoring that would
> share more of this logic between the two cases, can you at least add a
> comment in __libc_setup_tls that points to the implementation of the
> matching logic in the dynamic-linking case?
>
Here is the updated patch.
--
H.J.
--
We need to align TCB offset to the maximum alignment for TLS_TCB_AT_TP
targets, similar to what _dl_allocate_tls_storage in elf/dl-tls.c does.
[BZ #18383]
* csu/libc-tls.c (__libc_setup_tls): Align TCB offset to the
maximum alignment for TLS_TCB_AT_TP targets.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Align-TCB-offset-to-the-maximum-alignment.patch
Type: text/x-patch
Size: 1254 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20150507/9966fc36/attachment.bin>
More information about the Libc-alpha
mailing list