[PATCH] sha2: new header <sha2.h>

[Mike Frysinger]

On 25 Mar 2015 23:10, Shawn Landden wrote:
> Export the SHA2 family of functions.

you should write a proper ChangeLog entry

> --- /dev/null
> +++ b/include/sha2.h

this file is missing a proper header block (licensing/copyright/etc...)

> +/* 256 bits is 32 bytes
> + * for sha2-224 truncate from end after calling sha256_final()
> + */

GNU style says use full sentences, two spaces at th eend, and cuddle the 
trailing */ marker

> +typedef struct {
> +       char __internal_state[352];

only two spaces indent
-mike
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20150326/5ba0c98e/attachment.sig>