[COMMITTED PATCH] Avoid C++ tests when the C++ cannot be linked.

Carlos O'Donell carlos@redhat.com
Sat Mar 7 18:37:00 GMT 2015


On 03/06/2015 07:37 PM, Roland McGrath wrote:
>> I don't like this. The semantics I would rather have are that all such
>> tests fail, not fail to build, but fail. Then the results of `make check`
>> represent reality with all the C++ tests failing because you don't have
>> a libstdc++. This way it's clear that you haven't passed all of the testing
>> for glibc.
> 
> I don't like the conflation of unbuildable with failed.  What we need is
> the possibility of UNSUPPORTED as an outcome for our tests.  I'll send a
> change in that direction.

Good point. I like UNSUPPORTED better. My worry is that these tests simply
go missing and we don't notice. Fail safe is better.

Cheers,
Carlos.



More information about the Libc-alpha mailing list