[PATCH] Replace __attribute__((visibility("protected")))

[H.J. Lu]

On Fri, Mar 6, 2015 at 2:59 PM, Roland McGrath <roland@hack.frob.com> wrote:
>> On Fri, Mar 6, 2015 at 2:28 PM, Roland McGrath <roland@hack.frob.com> wrote:
>> > It needs comments.
>>
>> Did you mean duplicate my commit log to each
>> __attribute__ ((visibility ("protected"))) change?
>> What about existing
>>
>> asm (".protected xxx");
>>
>> Do they also need comments?  I don't think it is necessary
>> since the commit log explains why a change is made.
>
> What's necessary is that comments next to the actual code explain why it's
> any nonobvious way it is.  In this case, you need a short comment
> mentioning the GCC bug in each place that you're avoiding using the obvious
> compiler feature because of a bug.

Here is the updated patch.  OK to install?

Thanks.

-- 
H.J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Replace-__attribute__-visibility-protected.patch
Type: text/x-patch
Size: 2307 bytes
Desc: not available
URL: <http://sourceware.org/pipermail/libc-alpha/attachments/20150306/79b873fa/attachment.bin>