[PATCH] Add new script add-abilist.py

Florian Weimer fweimer@redhat.com
Thu Mar 5 21:01:00 GMT 2015


On 03/05/2015 08:30 PM, Carlos O'Donell wrote:
> On 03/02/2015 04:02 PM, Florian Weimer wrote:
>> On 03/02/2015 09:59 PM, Roland McGrath wrote:
>>>> It's very difficult to find. :-)  I haven't tried it, but I think it
>>>> only patches the current abilist file, and not the other architectures.
>>>
>>> That's true.  It does an empirical update to the actual new reality, rather
>>> than a specified updated to a putative new reality.
>>
>> I think both approaches have their advantages, at least for function
>> symbols.  Data symbols with their size information are more tricky.
> 
> The `make update-abi` method that Roland describes is part of the general
> glibc `Release` documentation here and referenced from the `Release`
> process followed by a release manager or machine maintainer during each
> release:
> 
> https://sourceware.org/glibc/wiki/Regeneration

I was under the impression it is the job of the patch submitter to
ensure that a patch does not cause *known* test suite failures on any
architecture.  To me, this clearly means that I have to update the
*.abilist files in any patch that updates the ABI.

Doing it at release time might work as well, but it seems much better to
me to avoid any known test suite failures during development, so that
interpreting test suite results is easy as possible.

-- 
Florian Weimer / Red Hat Product Security



More information about the Libc-alpha mailing list