[PATCH] Fix dynamic linker issue with bind-now

[Petar Jovanovic]

-----Original Message-----
From: Mike Frysinger [mailto:vapier@gentoo.org] 
Sent: Monday, March 2, 2015 7:29 AM
To: Petar Jovanovic
Cc: libc-alpha@sourceware.org; petar.jovanovic@imgtec.com
Subject: Re: [PATCH] Fix dynamic linker issue with bind-now

>shouldn't the source file be compiled w/-fPIE too ?

In the new version of the patch, this has been changed, so no CFLAGS are
required.

> do you need the IS_IN_build define ?  i'm not seeing it used.
It was required for the use of "-O0". Now it is not needed anymore in v3.


>> +tst-split-dynreloc-ENV = LD_BIND_NOW=1

>do you need to use the env var ?  pass -Wl,-z,now via LDFLAGS instead ?

Done.

> this should be at the top of the file -- move the includes/globals/etc... below

Done.

> +int
> +main (void)
> +{
> +  printf ("%s\n", foo);
> +  return 0;
> +}

> please use test-skeleton.c.  look at time/tst-ftime.c as a simple example.

Done.

Take a look at v3 of the change. Thanks.

Regards,
Petar