[PATCH 06/25] Add struct scratch_buffer and its internal helper functions

Florian Weimer fweimer@redhat.com
Mon Mar 2 09:40:00 GMT 2015


On 03/02/2015 10:35 AM, Andreas Schwab wrote:
> Florian Weimer <fweimer@redhat.com> writes:
> 
>> +#pragma once
> 
> Don't use pragma once.

Why?  The GCC implementation was fixed ages ago, and it's not an
installed header file.

>> +  GLIBC_2.22 {
>> +    __libc_scratch_buffer_grow;
>> +    __libc_scratch_buffer_grow_preserve;
>> +    __libc_scratch_buffer_set_array_size;
> 
> Are they supposed to be used outside of glibc?  Since scratch_buffer.h
> isn't installed, it doesn't look like.

See the commit message.  nscd and some of the NSS modules need these
symbols.

-- 
Florian Weimer / Red Hat Product Security



More information about the Libc-alpha mailing list