[PATCH][BZ #18441] fix sorting multibyte charsets with an improper locale

Andreas Schwab schwab@linux-m68k.org
Mon Jun 29 14:21:00 GMT 2015


Ondřej Bílka <neleai@seznam.cz> writes:

> On Sat, Jun 27, 2015 at 11:50:10PM +0200, Andreas Schwab wrote:
>> Ondřej Bílka <neleai@seznam.cz> writes:
>> 
>> > On Sat, Jun 27, 2015 at 10:07:17PM +0200, Andreas Schwab wrote:
>> >> Ondřej Bílka <neleai@seznam.cz> writes:
>> >> 
>> >> > *((uint16_t *) runp->mbs)
>> >> > (index << 12) ^ *((uint16_t *) (runp->mbs+1));
>> >> 
>> >> Either of these will be unaligned.
>> >> 
>> > Which as its used to index array of size 256 * 256 is what we want.
>> 
>> This doesn't make any sense.
>> 
> Yes, was writing that while bit drunk so I somewhat read that as unsigned.
> These should be guarded with_STRING_ARCH_unaligned.

localedef doesn't need micro-optimizations.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."



More information about the Libc-alpha mailing list