[PATCH] Inline C99 math functions

Carlos O'Donell carlos@redhat.com
Tue Jun 16 20:07:00 GMT 2015


On 06/15/2015 01:00 PM, Joseph Myers wrote:
> On Mon, 15 Jun 2015, Wilco Dijkstra wrote:
> 
>>> Where are the benchmarks for this?  Please put them in benchtests so
>>> actual reproducible figures can be given.  That's the standard practice
>>> for any change being justified on the basis of performance.
>>
>> I'll add a benchmark in another patch - it's not trivial as benchtest is not
>> suitable to accurately time very simple functions, especially when inlined...
> 
> Well, the benchmark should come first....

Agreed.

If it's not trivial to test the performance... then how did you test it?

How do I test it when reviewing the patch?

Cheers,
Carlos.



More information about the Libc-alpha mailing list