[PATCH 7/14] [x86_64] Vector math functions (log and tests)

[Joseph Myers]

On Mon, 15 Jun 2015, Andrew Senkevich wrote:

> 2015-06-12 0:47 GMT+03:00 Joseph Myers <joseph@codesourcery.com>:
> > On Wed, 10 Jun 2015, Andrew Senkevich wrote:
> >
> >> +/* Workaround to exclude unnecessary symbol aliases in libmvec
> >> +   while GCC creates the vector names based on scalar asm name.  */
> >
> > I think the GCC list discussion of possible better approaches to this
> > issue should be started first, with the comment referencing the
> > discussion.
> >
> >> +        movsd     -4218816(%r8,%rdx), %xmm1
> >
> > Where does this magic constant -4218816, that appears several times in the
> > patch, come from?  It seems like something that should have a #define in a
> > header, with a meaningful name and a comment explaining its semantics.
> 
> Attached patch contains these parts updated. Ok?

OK.

-- 
Joseph S. Myers
joseph@codesourcery.com