[PATCH 2/14] [x86_64] Vector math functions (added vector cos tests)

[Joseph Myers]

On Fri, 5 Jun 2015, Andrew Senkevich wrote:

> But current design was discussed and approved in december 2014, and
> already 5 patches with this current design were committed.

I can't find anything in December 2014 that looks to me like approval of 
this aspect of the design of patch 9/N (as it was then), just discussion 
of other issues with duplication in the code and incremental refactoring 
of it.

I don't think my comments in any way conflict with the pieces that have 
already been committed; they are specifically about the arrangement of 
things that are new in this patch (namely, definitions and declarations 
for wrapper functions used in testing, that are sufficiently mechanical 
that they should not need repeating for every (function, vector format) 
pair).

> Now I have series of 14 patches ready and such refactoring at this
> moment is enough significant effort. So I propose to add this
> refactoring as additional patch after this series. Is it ok?

No, I think the subsequent patches show up a deficiency in how each new 
function is tested, and so that should be cleaned up to reduce duplication 
before the second new function is added, rather than each patch adding 
more avoidable duplication of boilerplate test code.  It's unavoidable 
that sometimes adding more functions shows up design issues that weren't 
apparent with the addition of the first function.

-- 
Joseph S. Myers
joseph@codesourcery.com